Remove arbitrary sleeps from shutdown handling - #220
Merged
Conversation
Replace king's 1s sleep with event-driven QUIC drain wait that returns as soon as all lings disconnect (with 5s timeout as safety net). Remove ling's 750ms sleep entirely since it serves no purpose. Closes #16
firecow
force-pushed
the
remove-shutdown-sleeps
branch
from
March 1, 2026 18:59
b8a2659 to
8990e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.Sleepwith event-driven QUIC drain wait (5s timeout safety net)time.Sleepentirely — no purpose after sync completesTest plan
go test ./...)go test -tags=integration ./test/integration/...)Closes #16